Messages in this thread | | | From | Andy Shevchenko <> | Date | Mon, 27 Jul 2020 22:44:19 +0300 | Subject | Re: [PATCH v4 3/3] usb: dwc2: don't use ID/Vbus detection if usb-role-switch on STM32MP15 SoCs |
| |
On Mon, Jul 27, 2020 at 10:04 PM Martin Blumenstingl <martin.blumenstingl@googlemail.com> wrote: > On Mon, Jul 27, 2020 at 11:23 AM Amelie Delaunay <amelie.delaunay@st.com> wrote:
> > - p->activate_stm_id_vb_detection = true; > > + p->activate_stm_id_vb_detection = > > + !of_property_read_bool(np, "usb-role-switch"); > the rest of params.c uses device_property_read_* instead of of_read_property_* > I thought I'd mention it so you can decide yourself whether this is > fine or needs to be changed
Better to change and leave all on one line.
-- With Best Regards, Andy Shevchenko
| |