lkml.org 
[lkml]   [2020]   [Jul]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] drivers/net/wan/lapbether: Use needed_headroom instead of hard_header_len
Hi Cong Wang,

I'm wishing to change a driver from using "hard_header_len" to using
"needed_headroom" to declare its needed headroom. I submitted a patch
and it is decided it needs to be reviewed. I see you participated in
"hard_header_len vs needed_headroom" discussions in the past. Can you
help me review this patch? Thanks!

The patch is at:
http://patchwork.ozlabs.org/project/netdev/patch/20200726110524.151957-1-xie.he.0141@gmail.com/

In my understanding, hard_header_len should be the length of the header
created by dev_hard_header. Any additional headroom needed should be
declared in needed_headroom instead of hard_header_len. I came to this
conclusion by examining the logic of net/packet/af_packet.c:packet_snd.

What do you think?

Thanks!

\
 
 \ /
  Last update: 2020-07-27 21:42    [W:0.073 / U:0.384 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site