Messages in this thread | | | Date | Mon, 27 Jul 2020 14:40:53 -0400 | From | Vivek Goyal <> | Subject | Re: [PATCH v4] kvm,x86: Exit to user space in case page fault error |
| |
On Mon, Jul 27, 2020 at 06:09:32PM +0200, Vitaly Kuznetsov wrote: > Vivek Goyal <vgoyal@redhat.com> writes: > > > On Mon, Jul 20, 2020 at 05:13:59PM -0400, Vivek Goyal wrote: > >> Page fault error handling behavior in kvm seems little inconsistent when > >> page fault reports error. If we are doing fault synchronously > >> then we capture error (-EFAULT) returned by __gfn_to_pfn_memslot() and > >> exit to user space and qemu reports error, "error: kvm run failed Bad address". > > > > Hi Vitaly, > > > > A gentle reminder. How does this patch look now? > > > > Sorry, I even reviewd it but never replied. It looks good to me! > > Reviewed-by: Vitaly Kuznetsov <vkuznets@redhat.com>
Thanks Vitaly.
Paolo, what do you think about this patch. Do you have concerns with this. Can this be merged.
Thanks Vivek
| |