Messages in this thread | | | Subject | Re: [PATCH v3 00/10] ASoC: qdsp6: add gapless compressed audio support | From | Pierre-Louis Bossart <> | Date | Mon, 27 Jul 2020 10:24:34 -0500 |
| |
On 7/27/20 4:37 AM, Srinivas Kandagatla wrote: > This patchset adds gapless compressed audio support on q6asm. > Gapless on q6asm is implemented using 2 streams in a single q6asm session. > > First few patches such as stream id per each command, gapless flags > and silence meta data are for preparedness for adding gapless support. > Last patch implements copy callback to allow finer control over buffer offsets, > specially in partial drain cases. > > This patchset is tested on RB3 aka DB845c platform. > > This patchset as it is will support gapless however QDSP can also > support switching decoders on a single stream. Patches to support such feature > are send in different patchset which involves adding generic interfaces. > > Thanks, > srini
I've run out of comments :-)
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> Changes since v2:(mostly suggested by Pierre) > - removed unnessary kernel style comments, > - moved TIMESTAMP flag to respective patch. > - move preparatory code from gapless support patch to new one. > - fix subject prefix of one patch. > - add comments to clarify valid stream_ids > > Srinivas Kandagatla (10): > ASoC: q6asm: rename misleading session id variable > ASoC: q6asm: make commands specific to streams > ASoC: q6asm: use flags directly from q6asm-dai > ASoC: q6asm: add length to write command token > ASoC: q6asm: add support to remove intial and trailing silence > ASoC: q6asm: add support to gapless flag in q6asm open > ASoC: q6asm-dai: add next track metadata support > ASoC: q6asm-dai: prepare set params to accept profile change > ASoC: q6asm-dai: add gapless support > ASoC: q6asm-dai: add support to copy callback > > sound/soc/qcom/qdsp6/q6asm-dai.c | 414 +++++++++++++++++++++++-------- > sound/soc/qcom/qdsp6/q6asm.c | 169 +++++++++---- > sound/soc/qcom/qdsp6/q6asm.h | 49 ++-- > 3 files changed, 469 insertions(+), 163 deletions(-) >
| |