lkml.org 
[lkml]   [2020]   [Jul]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 006/138] scsi: scsi_transport_spi: Fix function pointer check
    Date
    From: Tom Rix <trix@redhat.com>

    [ Upstream commit 5aee52c44d9170591df65fafa1cd408acc1225ce ]

    clang static analysis flags several null function pointer problems.

    drivers/scsi/scsi_transport_spi.c:374:1: warning: Called function pointer is null (null dereference) [core.CallAndMessage]
    spi_transport_max_attr(offset, "%d\n");
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

    Reviewing the store_spi_store_max macro

    if (i->f->set_##field)
    return -EINVAL;

    should be

    if (!i->f->set_##field)
    return -EINVAL;

    Link: https://lore.kernel.org/r/20200627133242.21618-1-trix@redhat.com
    Reviewed-by: James Bottomley <jejb@linux.ibm.com>
    Signed-off-by: Tom Rix <trix@redhat.com>
    Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/scsi/scsi_transport_spi.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/scsi/scsi_transport_spi.c b/drivers/scsi/scsi_transport_spi.c
    index f8661062ef954..f3d5b1bbd5aa7 100644
    --- a/drivers/scsi/scsi_transport_spi.c
    +++ b/drivers/scsi/scsi_transport_spi.c
    @@ -339,7 +339,7 @@ store_spi_transport_##field(struct device *dev, \
    struct spi_transport_attrs *tp \
    = (struct spi_transport_attrs *)&starget->starget_data; \
    \
    - if (i->f->set_##field) \
    + if (!i->f->set_##field) \
    return -EINVAL; \
    val = simple_strtoul(buf, NULL, 0); \
    if (val > tp->max_##field) \
    --
    2.25.1


    \
     
     \ /
      Last update: 2020-07-27 16:37    [W:4.161 / U:0.128 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site