lkml.org 
[lkml]   [2020]   [Jul]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] staging: rtl8723bs: include: Fix coding style errors
On Sun, Jul 26, 2020 at 01:32:15PM +0530, Aditya Jain wrote:
> Fixing ERROR: "foo * bar" should be "foo *bar" in hal_phy_cfg.h
> as reported by checkpatch.pl
>
> Signed-off-by: Aditya Jain <aditya.jainadityajain.jain@gmail.com>
> ---
> .../staging/rtl8723bs/include/hal_phy_cfg.h | 18 +++++++++---------
> 1 file changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/include/hal_phy_cfg.h b/drivers/staging/rtl8723bs/include/hal_phy_cfg.h
> index 419ddb0733aa..fd5f377bad4f 100644
> --- a/drivers/staging/rtl8723bs/include/hal_phy_cfg.h
> +++ b/drivers/staging/rtl8723bs/include/hal_phy_cfg.h
> @@ -42,7 +42,7 @@ u32 Data
>
> u32
> PHY_QueryRFReg_8723B(
> -struct adapter * Adapter,
> +struct adapter *Adapter,
> u8 eRFPath,
> u32 RegAddr,
> u32 BitMask

Ick, these are all horrid. How about just making these all on a single
line like most functions have them instead of this one cleanup?

Same for the other changes you made in this file.

thanks,

greg k-h

\
 
 \ /
  Last update: 2020-07-26 10:27    [W:0.216 / U:0.128 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site