Messages in this thread | | | Date | Sun, 26 Jul 2020 19:25:49 +0200 | From | Sam Ravnborg <> | Subject | Re: [PATCH 1/2] drm/fourcc: fix Amlogic Video Framebuffer Compression macro |
| |
Hi Neil.
On Thu, Jul 23, 2020 at 11:05:50AM +0200, Neil Armstrong wrote: > Fix the Amlogic Video Framebuffer Compression modifier macro to > correctly add the layout options, a pair of parenthesis was missing. > > Fixes: d6528ec88309 ("drm/fourcc: Add modifier definitions for describing Amlogic Video Framebuffer Compression") > Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> Looks correct just looking at the patch below. Acked-by: Sam Ravnborg <sam@ravnborg.org>
I assume you will apply the patch.
Sam
> --- > include/uapi/drm/drm_fourcc.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/uapi/drm/drm_fourcc.h b/include/uapi/drm/drm_fourcc.h > index 4bee7de5f306..82f327801267 100644 > --- a/include/uapi/drm/drm_fourcc.h > +++ b/include/uapi/drm/drm_fourcc.h > @@ -1004,7 +1004,7 @@ drm_fourcc_canonicalize_nvidia_format_mod(__u64 modifier) > #define DRM_FORMAT_MOD_AMLOGIC_FBC(__layout, __options) \ > fourcc_mod_code(AMLOGIC, \ > ((__layout) & __fourcc_mod_amlogic_layout_mask) | \ > - ((__options) & __fourcc_mod_amlogic_options_mask \ > + (((__options) & __fourcc_mod_amlogic_options_mask) \ > << __fourcc_mod_amlogic_options_shift)) > > /* Amlogic FBC Layouts */ > -- > 2.22.0 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
| |