lkml.org 
[lkml]   [2020]   [Jul]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC PATCH] iwlwifi: yoyo: don't print failure if debug firmware is missing
On Thu, Jun 25, 2020 at 06:52:10PM +0200, Wolfram Sang wrote:
> Missing this firmware is not fatal, my wifi card still works. Even more,
> I couldn't find any documentation what it is or where to get it. So, I
> don't think the users should be notified if it is missing. If you browse
> the net, you see the message is present is in quite some logs. Better
> remove it.
>
> Signed-off-by: Wolfram Sang <wsa@kernel.org>
> ---

Any input on this? Or people I should add to CC?

>
> This is only build tested because I wanted to get your opinions first. I
> couldn't find any explanation about yoyo, so I am entering unknown
> territory here.
>
> drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c b/drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c
> index 7987a288917b..f180db2936e3 100644
> --- a/drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c
> +++ b/drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c
> @@ -468,7 +468,7 @@ void iwl_dbg_tlv_load_bin(struct device *dev, struct iwl_trans *trans)
> if (!iwlwifi_mod_params.enable_ini)
> return;
>
> - res = request_firmware(&fw, "iwl-debug-yoyo.bin", dev);
> + res = firmware_request_nowarn(&fw, "iwl-debug-yoyo.bin", dev);
> if (res)
> return;
>
> --
> 2.20.1
>
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2020-07-26 17:27    [W:0.107 / U:0.200 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site