[lkml]   [2020]   [Jul]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] io: Fix return type of _inb and _inl
On Sun, Jul 26, 2020 at 6:14 AM Stafford Horne <> wrote:
> The return type of functions _inb, _inw and _inl are all u16 which looks
> wrong. This patch makes them u8, u16 and u32 respectively.
> The original commit text for these does not indicate that these should
> be all forced to u16.

Is it in alight with all architectures? that support this interface natively?

(Return value is arch-dependent AFAIU, so it might actually return
16-bit for byte read, but I agree that this is weird for 32-bit value.
I think you have elaborate more in the commit message)

With Best Regards,
Andy Shevchenko

 \ /
  Last update: 2020-07-26 11:01    [W:0.056 / U:0.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site