Messages in this thread |  | | Date | Sat, 25 Jul 2020 07:48:44 +0200 | From | Greg KH <> | Subject | Re: [PATCH 14216/14216] ALSA: usb-audio: This patch for prevent auto wakeup from s3 trig by usb disconnect signal from Lenovo Thinkcentre TI024Gen3 USB-audio. |
| |
On Sat, Jul 25, 2020 at 12:01:55PM +0800, penghao wrote: > From: "penghao@deepin.com" <penghao@deepin.com> > > TI024Gen3 USB-audio is controlled by TI024Gen3,when TI024Gens > enter sleep mode, USB-audio will disconnect from USB bus port, > so disabled the /sys/bus/usb/*/power/wakeup Fixesimmediately > wakup form s3 state
Why the indentation?
> > Signed-off-by: penghao@uniontech.com <penghao@uniontech.com> > Signed-off-by: penghao@deepin.com <penghao@deepin.com>
We need a name, not just an email address.
And where are the 14215 other patches in this patch series?
> --- > sound/usb/card.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/sound/usb/card.c b/sound/usb/card.c > index 2644a5ae2b75..969c3809e051 100644 > --- a/sound/usb/card.c > +++ b/sound/usb/card.c > @@ -640,6 +640,12 @@ static int usb_audio_probe(struct usb_interface *intf, > } > } > dev_set_drvdata(&dev->dev, chip); > + /* > + * ALSA: usb-audio: Add prevent wakeup from s3 state trig by lenovo > + * ThinkCentre TI024Gen3 USB-audio > + */ > + if ((usb_id->idVendor == 0x17ef) && (usb_id->idProduct == 0xa012)) > + device_set_wakeup_enable(&dev->dev, 0);
Shouldn't there be a quirk for this type of device that can be used instead?
thanks,
greg k-h
|  |