lkml.org 
[lkml]   [2020]   [Jul]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 05/29] memory: jz4780-nemc: Do not enable by default on every compile test
On Fri, Jul 24, 2020 at 03:45:37PM +0200, Arnd Bergmann wrote:
> On Fri, Jul 24, 2020 at 9:41 AM Krzysztof Kozlowski <krzk@kernel.org> wrote:
> >
> > When compile testing, enable the driver by default only on MIPS
> > architecture.
> >
> > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> >
> > ---
> >
> > Changes since v1:
> > 1. New patch
> @@ -141,7 +141,7 @@ config FSL_IFC
> >
> > config JZ4780_NEMC
> > bool "Ingenic JZ4780 SoC NEMC driver"
> > - default y
> > + default y if MIPS
> > depends on MIPS || COMPILE_TEST
>
>
> Actually I think this should be 'default MACH_INGENIC',
> and probably also 'depends on MACH_INGENIC || COMPILE_TEST'.

Makes sense, especially for default.

For the depends, there is also MTD_NAND_JZ4780 (depending on
JZ4780_NEMC) which also requires MIPS. I could fix both then.

Best regards,
Krzysztof

\
 
 \ /
  Last update: 2020-07-24 15:53    [W:1.277 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site