Messages in this thread | | | Subject | Re: [PATCH -next] arm64: Export __cpu_logical_map | From | Anshuman Khandual <> | Date | Fri, 24 Jul 2020 16:06:28 +0530 |
| |
On 07/24/2020 03:00 PM, Catalin Marinas wrote: > On Fri, Jul 24, 2020 at 01:46:18PM +0530, Anshuman Khandual wrote: >> On 07/24/2020 08:38 AM, Kefeng Wang wrote: >>> On 2020/7/24 11:04, Kefeng Wang wrote: >>>> ERROR: modpost: "__cpu_logical_map" [drivers/cpufreq/tegra194-cpufreq.ko] undefined! >>>> >>>> ARM64 tegra194-cpufreq driver use cpu_logical_map, export >>>> __cpu_logical_map to fix build issue. >> Commit 887d5fc82cb4 ("cpufreq: Add Tegra194 cpufreq driver") which adds >> this particular driver is present just on linux-next. But as expected, >> the driver does not use __cpu_logical_map directly but instead accesses >> it via cpu_logical_map() wrapper. Wondering, how did you even trigger >> the modpost error ? > Since the wrapper is a macro, it just expands to __cpu_logical_map[]. >
Ahh, right. Existing cpu_logical_map() is not a true wrapper and it makes sense to convert that into one.
| |