Messages in this thread Patch in this message | | | Date | Fri, 24 Jul 2020 08:33:47 -0000 | From | "tip-bot2 for Peter Zijlstra" <> | Subject | [tip: sched/fifo] sched,ivtv: Convert to sched_set_fifo*() |
| |
The following commit has been merged into the sched/fifo branch of tip:
Commit-ID: 73f73cc2432acf2e1c8a1ce0720eaced7b5dda16 Gitweb: https://git.kernel.org/tip/73f73cc2432acf2e1c8a1ce0720eaced7b5dda16 Author: Peter Zijlstra <peterz@infradead.org> AuthorDate: Tue, 21 Apr 2020 12:09:13 +02:00 Committer: Peter Zijlstra <peterz@infradead.org> CommitterDate: Mon, 15 Jun 2020 14:10:22 +02:00
sched,ivtv: Convert to sched_set_fifo*()
Because SCHED_FIFO is a broken scheduler model (see previous patches) take away the priority field, the kernel can't possibly make an informed decision.
Effectively changes from 99 to 50.
Cc: awalls@md.metrocast.net Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org> Reviewed-by: Ingo Molnar <mingo@kernel.org> Acked-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> Tested-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> --- drivers/media/pci/ivtv/ivtv-driver.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/media/pci/ivtv/ivtv-driver.c b/drivers/media/pci/ivtv/ivtv-driver.c index b1dde1b..28acb14 100644 --- a/drivers/media/pci/ivtv/ivtv-driver.c +++ b/drivers/media/pci/ivtv/ivtv-driver.c @@ -737,8 +737,6 @@ done: */ static int ivtv_init_struct1(struct ivtv *itv) { - struct sched_param param = { .sched_priority = 99 }; - itv->base_addr = pci_resource_start(itv->pdev, 0); itv->enc_mbox.max_mbox = 2; /* the encoder has 3 mailboxes (0-2) */ itv->dec_mbox.max_mbox = 1; /* the decoder has 2 mailboxes (0-1) */ @@ -758,7 +756,7 @@ static int ivtv_init_struct1(struct ivtv *itv) return -1; } /* must use the FIFO scheduler as it is realtime sensitive */ - sched_setscheduler(itv->irq_worker_task, SCHED_FIFO, ¶m); + sched_set_fifo(itv->irq_worker_task); kthread_init_work(&itv->irq_work, ivtv_irq_work_handler);
| |