Messages in this thread | | | Subject | Re: [char-misc-next 6/6] mei: hw: don't use one element arrays | From | "Gustavo A. R. Silva" <> | Date | Thu, 23 Jul 2020 11:49:22 -0500 |
| |
On 7/23/20 09:59, Tomas Winkler wrote: > Replace the single element arrays with a simple value type u8 reserved, > even thought is is not used for dynamically sized trailing elements > it confuses the effort of replacing one-element arrays with > flexible arrays for that purpose. > > Link: https://github.com/KSPP/linux/issues/79 > Cc: Gustavo A. R. Silva <gustavoars@kernel.org> > Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Reviewed-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Thanks -- Gustavo
> --- > drivers/misc/mei/hw.h | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/misc/mei/hw.h b/drivers/misc/mei/hw.h > index b1a8d5ec88b3..26fa92cb7f7a 100644 > --- a/drivers/misc/mei/hw.h > +++ b/drivers/misc/mei/hw.h > @@ -1,6 +1,6 @@ > /* SPDX-License-Identifier: GPL-2.0 */ > /* > - * Copyright (c) 2003-2018, Intel Corporation. All rights reserved > + * Copyright (c) 2003-2020, Intel Corporation. All rights reserved > * Intel Management Engine Interface (Intel MEI) Linux driver > */ > > @@ -319,7 +319,7 @@ struct hbm_props_response { > u8 hbm_cmd; > u8 me_addr; > u8 status; > - u8 reserved[1]; > + u8 reserved; > struct mei_client_properties client_properties; > } __packed; > > @@ -352,7 +352,7 @@ struct hbm_add_client_response { > u8 hbm_cmd; > u8 me_addr; > u8 status; > - u8 reserved[1]; > + u8 reserved; > } __packed; > > /** > @@ -461,7 +461,7 @@ struct hbm_notification { > u8 hbm_cmd; > u8 me_addr; > u8 host_addr; > - u8 reserved[1]; > + u8 reserved; > } __packed; > > /** >
| |