lkml.org 
[lkml]   [2020]   [Jul]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [char-misc-next 1/6] mei: hbm: use sizeof of variable instead of struct type
    On Thu, Jul 23, 2020 at 05:59:22PM +0300, Tomas Winkler wrote:
    > There is a possibility of bug when variable type has changed but
    > corresponding struct passed to the sizeof has not.
    >
    > Cc: Gustavo A. R. Silva <gustavoars@kernel.org>
    > Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
    > ---
    > drivers/misc/mei/hbm.c | 74 ++++++++++++++++++------------------------
    > 1 file changed, 32 insertions(+), 42 deletions(-)

    This doesn't apply to my tree as I've applied Gustavo's patch. Should I
    revert that first?

    thanks,

    greg k-h

    \
     
     \ /
      Last update: 2020-07-23 17:14    [W:3.766 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site