lkml.org 
[lkml]   [2020]   [Jul]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH V3] Softirq:avoid large sched delay from the pending softirqs
On Thu, Jul 23, 2020 at 9:41 PM Thomas Gleixner <tglx@linutronix.de> wrote:
>
> qianjun.kernel@gmail.com writes:
> > From: jun qian <qianjun.kernel@gmail.com>
> > + /*
> > + * the softirq's action has been running for too much time
> > + * so it may need to wakeup the ksoftirqd
> > + */
> > + if (need_resched() && ktime_get() > end)
> > + break;
>
> As per my reply on V2 this is leaking non handled pending bits. If you
> do a V4, can you please use sched_clock() instead of ktime_get()?
>
The reason why the non handled pending bits leaked is
set_softirq_pending(0) called in the start, if the
loop is broken, the not handled bit will leak. This is my
understanding, I am not sure if it is correct or not.
Looking forward to your reply.

Thank you so much.

> Thanks,
>
> tglx

\
 
 \ /
  Last update: 2020-07-23 16:12    [W:0.058 / U:0.108 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site