Messages in this thread | | | From | jun qian <> | Date | Thu, 23 Jul 2020 22:11:59 +0800 | Subject | Re: [PATCH V3] Softirq:avoid large sched delay from the pending softirqs |
| |
On Thu, Jul 23, 2020 at 9:41 PM Thomas Gleixner <tglx@linutronix.de> wrote: > > qianjun.kernel@gmail.com writes: > > From: jun qian <qianjun.kernel@gmail.com> > > + /* > > + * the softirq's action has been running for too much time > > + * so it may need to wakeup the ksoftirqd > > + */ > > + if (need_resched() && ktime_get() > end) > > + break; > > As per my reply on V2 this is leaking non handled pending bits. If you > do a V4, can you please use sched_clock() instead of ktime_get()? > The reason why the non handled pending bits leaked is set_softirq_pending(0) called in the start, if the loop is broken, the not handled bit will leak. This is my understanding, I am not sure if it is correct or not. Looking forward to your reply.
Thank you so much.
> Thanks, > > tglx
| |