Messages in this thread | | | From | Linus Walleij <> | Date | Thu, 23 Jul 2020 15:17:08 +0200 | Subject | Re: [PATCH 4/7] gpio: dwapb: Convert driver to using the GPIO-lib-based IRQ-chip |
| |
Hi Serge,
On Thu, Jul 23, 2020 at 3:39 AM Serge Semin <Sergey.Semin@baikalelectronics.ru> wrote:
> GPIO-lib provides a ready-to-use interface to initialize an IRQ-chip on > top of a GPIO chip. It's better from maintainability and readability > point of view to use one instead of supporting a hand-written Generic > IRQ-chip-based implementation. Moreover the new implementation won't > cause much functional overhead but will provide a cleaner driver code. > All of that makes the DW APB GPIO driver conversion pretty much justified > especially seeing a tendency of the other GPIO drivers getting converted > too.
Needless to say I am a big fan of this patch. It's what I wanted to do with the driver but was afraid to dry-code.
Please look into the minor nits pointed out by Andy and respin, I really want to apply this patch set.
Thanks, Linus Walleij
| |