lkml.org 
[lkml]   [2020]   [Jul]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 09/40] scsi: bfa: bfa_fcpim: Remove set but unused variable 'rp'
    Date
    This change subsequently makes 'rp_fcs' unused also.  Remove that too.

    Fixes the following W=1 kernel build warning(s):

    drivers/scsi/bfa/bfa_fcpim.c: In function ‘bfa_fcpim_lunmask_delete’:
    drivers/scsi/bfa/bfa_fcpim.c:2338:22: warning: variable ‘rp’ set but not used [-Wunused-but-set-variable]
    2338 | struct bfa_rport_s *rp = NULL;
    | ^~

    Cc: Anil Gurumurthy <anil.gurumurthy@qlogic.com>
    Cc: Sudarsana Kalluru <sudarsana.kalluru@qlogic.com>
    Signed-off-by: Lee Jones <lee.jones@linaro.org>
    ---
    drivers/scsi/bfa/bfa_fcpim.c | 8 +-------
    1 file changed, 1 insertion(+), 7 deletions(-)

    diff --git a/drivers/scsi/bfa/bfa_fcpim.c b/drivers/scsi/bfa/bfa_fcpim.c
    index 766f2b5ed2ab4..f6bf24084a47a 100644
    --- a/drivers/scsi/bfa/bfa_fcpim.c
    +++ b/drivers/scsi/bfa/bfa_fcpim.c
    @@ -2335,9 +2335,7 @@ bfa_fcpim_lunmask_delete(struct bfa_s *bfa, u16 vf_id, wwn_t *pwwn,
    wwn_t rpwwn, struct scsi_lun lun)
    {
    struct bfa_lun_mask_s *lunm_list;
    - struct bfa_rport_s *rp = NULL;
    struct bfa_fcs_lport_s *port = NULL;
    - struct bfa_fcs_rport_s *rp_fcs;
    int i;

    /* in min cfg lunm_list could be NULL but no commands should run. */
    @@ -2353,12 +2351,8 @@ bfa_fcpim_lunmask_delete(struct bfa_s *bfa, u16 vf_id, wwn_t *pwwn,
    port = bfa_fcs_lookup_port(
    &((struct bfad_s *)bfa->bfad)->bfa_fcs,
    vf_id, *pwwn);
    - if (port) {
    + if (port)
    *pwwn = port->port_cfg.pwwn;
    - rp_fcs = bfa_fcs_lport_get_rport_by_pwwn(port, rpwwn);
    - if (rp_fcs)
    - rp = rp_fcs->bfa_rport;
    - }
    }

    lunm_list = bfa_get_lun_mask_list(bfa);
    --
    2.25.1
    \
     
     \ /
      Last update: 2020-07-23 14:27    [W:4.197 / U:0.184 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site