lkml.org 
[lkml]   [2020]   [Jul]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 29/40] scsi: bnx2i: bnx2i_iscsi: Add, remove and edit some function parameter descriptions
    Date
    Fixes the following W=1 kernel build warning(s):

    drivers/scsi/bnx2i/bnx2i_iscsi.c:241: warning: Function parameter or member 'bnx2i_conn' not described in 'bnx2i_bind_conn_to_iscsi_cid'
    drivers/scsi/bnx2i/bnx2i_iscsi.c:241: warning: Excess function parameter 'conn' description in 'bnx2i_bind_conn_to_iscsi_cid'
    drivers/scsi/bnx2i/bnx2i_iscsi.c:470: warning: Excess function parameter 'cmd' description in 'bnx2i_destroy_cmd_pool'
    drivers/scsi/bnx2i/bnx2i_iscsi.c:595: warning: Function parameter or member 'cls_session' not described in 'bnx2i_drop_session'
    drivers/scsi/bnx2i/bnx2i_iscsi.c:595: warning: Excess function parameter 'hba' description in 'bnx2i_drop_session'
    drivers/scsi/bnx2i/bnx2i_iscsi.c:595: warning: Excess function parameter 'session' description in 'bnx2i_drop_session'
    drivers/scsi/bnx2i/bnx2i_iscsi.c:1290: warning: Function parameter or member 'ep' not described in 'bnx2i_session_create'
    drivers/scsi/bnx2i/bnx2i_iscsi.c:1979: warning: Function parameter or member 'bnx2i_ep' not described in 'bnx2i_ep_tcp_conn_active'
    drivers/scsi/bnx2i/bnx2i_iscsi.c:1979: warning: Excess function parameter 'ep' description in 'bnx2i_ep_tcp_conn_active'
    drivers/scsi/bnx2i/bnx2i_iscsi.c:2178: warning: Function parameter or member 'shost' not described in 'bnx2i_nl_set_path'
    drivers/scsi/bnx2i/bnx2i_iscsi.c:2178: warning: Function parameter or member 'params' not described in 'bnx2i_nl_set_path'
    drivers/scsi/bnx2i/bnx2i_iscsi.c:2178: warning: Excess function parameter 'buf' description in 'bnx2i_nl_set_path'

    Cc: QLogic-Storage-Upstream@qlogic.com
    Cc: Anil Veerabhadrappa <anilgv@broadcom.com>
    Cc: Eddie Wai <eddie.wai@broadcom.com>
    Signed-off-by: Lee Jones <lee.jones@linaro.org>
    ---
    drivers/scsi/bnx2i/bnx2i_iscsi.c | 16 +++++++---------
    1 file changed, 7 insertions(+), 9 deletions(-)

    diff --git a/drivers/scsi/bnx2i/bnx2i_iscsi.c b/drivers/scsi/bnx2i/bnx2i_iscsi.c
    index 0b28d44d35738..a9ffd89ec2c85 100644
    --- a/drivers/scsi/bnx2i/bnx2i_iscsi.c
    +++ b/drivers/scsi/bnx2i/bnx2i_iscsi.c
    @@ -228,7 +228,7 @@ static void bnx2i_setup_cmd_wqe_template(struct bnx2i_cmd *cmd)
    /**
    * bnx2i_bind_conn_to_iscsi_cid - bind conn structure to 'iscsi_cid'
    * @hba: pointer to adapter instance
    - * @conn: pointer to iscsi connection
    + * @bnx2i_conn: pointer to iscsi connection
    * @iscsi_cid: iscsi context ID, range 0 - (MAX_CONN - 1)
    *
    * update iscsi cid table entry with connection pointer. This enables
    @@ -463,7 +463,6 @@ static int bnx2i_alloc_bdt(struct bnx2i_hba *hba, struct iscsi_session *session,
    * bnx2i_destroy_cmd_pool - destroys iscsi command pool and release BD table
    * @hba: adapter instance pointer
    * @session: iscsi session pointer
    - * @cmd: iscsi command structure
    */
    static void bnx2i_destroy_cmd_pool(struct bnx2i_hba *hba,
    struct iscsi_session *session)
    @@ -582,8 +581,7 @@ static void bnx2i_free_mp_bdt(struct bnx2i_hba *hba)

    /**
    * bnx2i_drop_session - notifies iscsid of connection error.
    - * @hba: adapter instance pointer
    - * @session: iscsi session pointer
    + * @cls_session: iscsi cls session pointer
    *
    * This notifies iscsid that there is a error, so it can initiate
    * recovery.
    @@ -1277,7 +1275,7 @@ static int bnx2i_task_xmit(struct iscsi_task *task)

    /**
    * bnx2i_session_create - create a new iscsi session
    - * @cmds_max: max commands supported
    + * @ep: pointer to iscsi endpoint
    * @qdepth: scsi queue depth to support
    * @initial_cmdsn: initial iscsi CMDSN to be used for this session
    *
    @@ -1971,7 +1969,7 @@ static int bnx2i_ep_poll(struct iscsi_endpoint *ep, int timeout_ms)

    /**
    * bnx2i_ep_tcp_conn_active - check EP state transition
    - * @ep: endpoint pointer
    + * @bnx2i_ep: endpoint pointer
    *
    * check if underlying TCP connection is active
    */
    @@ -2014,9 +2012,9 @@ static int bnx2i_ep_tcp_conn_active(struct bnx2i_endpoint *bnx2i_ep)
    }


    -/*
    +/**
    * bnx2i_hw_ep_disconnect - executes TCP connection teardown process in the hw
    - * @ep: TCP connection (bnx2i endpoint) handle
    + * @bnx2i_ep: TCP connection (bnx2i endpoint) handle
    *
    * executes TCP connection teardown process
    */
    @@ -2171,8 +2169,8 @@ static void bnx2i_ep_disconnect(struct iscsi_endpoint *ep)

    /**
    * bnx2i_nl_set_path - ISCSI_UEVENT_PATH_UPDATE user message handler
    + * @shost: scsi host pointer
    * @buf: pointer to buffer containing iscsi path message
    - *
    */
    static int bnx2i_nl_set_path(struct Scsi_Host *shost, struct iscsi_path *params)
    {
    --
    2.25.1
    \
     
     \ /
      Last update: 2020-07-23 14:26    [W:4.287 / U:0.656 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site