lkml.org 
[lkml]   [2020]   [Jul]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] MIPS: CI20: Update defconfig for EFUSE.
Hi Zhou,

Le jeu. 23 juil. 2020 à 15:19, 周琰杰 (Zhou Yanjie)
<zhouyanjie@wanyeetech.com> a écrit :
> The commit 19c968222934 ("MIPS: DTS: CI20: make DM9000 Ethernet
> controller use NVMEM to find the default MAC address") add EFUSE
> node for DM9000 in CI20, however, the EFUSE driver is not selected,
> which will cause the DM9000 to fail to read the MAC address from
> EFUSE, causing the following issue:
>
> [FAILED] Failed to start Raise network interfaces.
>
> Fix this problem by select CONFIG_JZ4780_EFUSE by default in the
> ci20_defconfig.

Does it actually fix it on a clean 5.8-rc kernel?

From what I know, the efuse driver cannot probe, because the nemc
driver requests the complete memory resource, so the efuse driver's
devm_platform_ioremap_resource() fails.

I did send a patch to fix this
(https://lore.kernel.org/lkml/551a8560261543c1decb1d4d1671ec4b7fa52fdb.1582905653.git.hns@goldelico.com/),
but it's hard to have somebody merge it, because nobody maintains
drivers/memory/.

> Fixes: 19c968222934 ("MIPS: DTS: CI20: make DM9000 Ethernet
> controller use NVMEM to find the default MAC address").

That shouldn't be a fix IMHO - the devicetree was updated in one
commit, the config should be updated in another. The "bug" here is that
it wasn't done right away.

> Signed-off-by: 周琰杰 (Zhou Yanjie) <zhouyanjie@wanyeetech.com>

Btw - when you add a Fixes: tag to fix a commit that is not for the
kernel currently in RC phase, you need to Cc linux-stable as well.

Cheers,
-Paul

> ---
> arch/mips/configs/ci20_defconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/mips/configs/ci20_defconfig
> b/arch/mips/configs/ci20_defconfig
> index f433fad16073..ba26ba4de09a 100644
> --- a/arch/mips/configs/ci20_defconfig
> +++ b/arch/mips/configs/ci20_defconfig
> @@ -140,6 +140,7 @@ CONFIG_INGENIC_OST=y
> CONFIG_MEMORY=y
> CONFIG_PWM=y
> CONFIG_PWM_JZ4740=m
> +CONFIG_JZ4780_EFUSE=y
> CONFIG_EXT4_FS=y
> # CONFIG_DNOTIFY is not set
> CONFIG_AUTOFS_FS=y
> --
> 2.11.0
>


\
 
 \ /
  Last update: 2020-07-23 10:48    [W:0.050 / U:0.220 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site