Messages in this thread | | | From | Amir Goldstein <> | Date | Fri, 24 Jul 2020 06:47:24 +0300 | Subject | Re: [fsnotify] c738fbabb0: will-it-scale.per_process_ops -9.5% regression |
| |
On Fri, Jul 24, 2020 at 5:45 AM Rong Chen <rong.a.chen@intel.com> wrote: > > > > On 7/21/20 11:59 PM, Amir Goldstein wrote: > > On Tue, Jul 21, 2020 at 3:15 AM kernel test robot <rong.a.chen@intel.com> wrote: > >> Greeting, > >> > >> FYI, we noticed a -9.5% regression of will-it-scale.per_process_ops due to commit: > >> > >> > >> commit: c738fbabb0ff62d0f9a9572e56e65d05a1b34c6a ("fsnotify: fold fsnotify() call into fsnotify_parent()") > > Strange, that's a pretty dumb patch moving some inlined code from one > > function to > > another (assuming there are no fsnotify marks in this test). > > > > Unless I am missing something the only thing that changes slightly is > > an extra d_inode(file->f_path.dentry) deference. > > I can get rid of it. > > > > Is it possible to ask for a re-test with fix patch (attached)? > > Hi Amir, > > We failed to apply this patch, could you tell us the base commit or the > base branch? >
Hi Rong,
The patch is applied on top of the reported offending commit: c738fbabb0ff62d0f9a9572e56e65d05a1b34c6a ("fsnotify: fold fsnotify() call into fsnotify_parent()")
I pushed it to my github: https://github.com/amir73il/linux/commits/for_lkp
Thanks, Amir.
| |