lkml.org 
[lkml]   [2020]   [Jul]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/2] lib/Kconfig.debug: Make TEST_LOCKUP depend on module
From
Date
On 7/23/20 6:50 PM, Tiezhu Yang wrote:
> Since test_lockup is a test module to generate lockups, it is better to
> limit TEST_LOCKUP to module (=m) or disabled (=n) because we can not use
> the module parameters when CONFIG_TEST_LOCKUP=y.
>
> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>

Makes sense.

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> ---
> lib/Kconfig.debug | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
> index 9ad9210..18b7c67 100644
> --- a/lib/Kconfig.debug
> +++ b/lib/Kconfig.debug
> @@ -1035,6 +1035,7 @@ config WQ_WATCHDOG
>
> config TEST_LOCKUP
> tristate "Test module to generate lockups"
> + depends on m
> help
> This builds the "test_lockup" module that helps to make sure
> that watchdogs and lockup detectors are working properly.
>

\
 
 \ /
  Last update: 2020-07-24 04:12    [W:0.046 / U:0.092 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site