Messages in this thread | | | From | David Howells <> | Subject | Re: [PATCH] keys: asymmetric: fix error return code in software_key_query() | Date | Thu, 23 Jul 2020 08:31:23 +0100 |
| |
Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> wrote:
> > if (IS_ERR(tfm)) > > return PTR_ERR(tfm); > > > > + ret = -ENOMEM; > > This is extremely confusing to read way to handle 'ret'. > > Would be way more cleaner to be just simple and stupid: > > if (!key) { > ret = -ENOMEM; > goto error_free_tfm; > }
I agree, but we have some people who will (or who used to) moan at you for doing in four lines what you could've done in three. I don't know if this is still the standard.
David
| |