Messages in this thread | | | Date | Thu, 23 Jul 2020 23:44:10 +0200 | From | Pavel Machek <> | Subject | Re: [PATCH RFC leds + net-next v2 1/1] net: phy: marvell: add support for PHY LEDs via LED class |
| |
Hi!
> > +{ > > + struct phy_device *phydev = to_phy_device(cdev->dev->parent); > > + struct marvell_phy_led *led = to_marvell_phy_led(cdev); > > + u8 val; > > + > > + /* don't do anything if HW control is enabled */ > > + if (check_trigger && cdev->trigger == &marvell_hw_led_trigger) > > + return 0; > > I thought the brightness file disappeared when a trigger takes > over. So is this possible?
No.
When trigger is set, brightness controls "maximum" brightness LED can have (and can turn trigger off by setting brightness to 0). Interface is ... not quite nice. Pavel
-- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html [unhandled content-type:application/pgp-signature] | |