lkml.org 
[lkml]   [2020]   [Jul]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 2/2] crypto: Ingenic: Add hardware RNG for Ingenic JZ4780 and X1000.
From
Date
On 7/22/20 9:40 AM, 周琰杰 (Zhou Yanjie) wrote:
> diff --git a/drivers/char/hw_random/Kconfig b/drivers/char/hw_random/Kconfig
> index 0ad17efc96df..fcb06027cd88 100644
> --- a/drivers/char/hw_random/Kconfig
> +++ b/drivers/char/hw_random/Kconfig
> @@ -257,6 +257,21 @@ config HW_RANDOM_IMX_RNGC
>
> If unsure, say Y.
>
> +config HW_RANDOM_INGENIC_RNG
> + tristate "Ingenic Random Number Generator support"
> + depends on HW_RANDOM
> + depends on MACH_JZ4780 || MACH_X1000
> + default HW_RANDOM
> + ---help---

Just use:
help
here. See this for why:

commit 8f268881d7d278047b00eed54bbb9288dbd6ab23
Author: Masahiro Yamada <masahiroy@kernel.org>
Date: Tue Dec 17 20:51:51 2019 +0900

kconfig: remove ---help--- from documentation

Since commit 84af7a6194e4 ("checkpatch: kconfig: prefer 'help' over
'---help---'"), scripts/checkpatch.pl warns the use of ---help---.

Kconfig still supports ---help---, but new code should avoid using it.
Let's stop advertising it in documentation.

> + This driver provides kernel-side support for the Random Number Generator
> + hardware found in ingenic JZ4780 and X1000 SoC. MIPS Creator CI20 uses
> + JZ4780 SoC, YSH & ATIL CU1000-Neo uses X1000 SoC.
> +
> + To compile this driver as a module, choose M here: the
> + module will be called ingenic-rng.
> +
> + If unsure, say Y.
> +
> config HW_RANDOM_NOMADIK
> tristate "ST-Ericsson Nomadik Random Number Generator support"
> depends on ARCH_NOMADIK

thanks.
--
~Randy

\
 
 \ /
  Last update: 2020-07-22 20:28    [W:1.035 / U:0.388 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site