Messages in this thread | | | Subject | Re: [PATCH][next] tty: Avoid the use of one-element arrays | From | "Gustavo A. R. Silva" <> | Date | Wed, 22 Jul 2020 13:24:19 -0500 |
| |
On 7/17/20 01:10, Jiri Slaby wrote: > On 16. 07. 20, 20:08, Gustavo A. R. Silva wrote: >> One-element arrays are being deprecated[1]. Replace the one-element arrays >> with simple value types 'char reserved_char' and 'compat_int_t reserved'[2], >> once it seems these are just placeholders for alignment. >> >> Also, while there, use the preferred form for passing a size of a struct. >> The alternative form where struct name is spelled out hurts readability >> and introduces an opportunity for a bug when the variable type is changed >> but the corresponding sizeof that is passed as argument is not. >> >> Lastly, fix the checkpatch.pl warnings below: >> >> ERROR: code indent should use tabs where possible >> + char reserved_char;$ >> >> WARNING: please, no spaces at the start of a line >> + char reserved_char;$ >> >> ERROR: code indent should use tabs where possible >> + compat_int_t reserved;$ >> >> WARNING: please, no spaces at the start of a line >> + compat_int_t reserved;$ > > May I ask you to send a follow-up patch to fix the whole structure's > indentation? >
Hi Jiri,
Sure thing. I'll fix that up and send v2, shortly.
Thanks -- Gustavo
>> [1] https://github.com/KSPP/linux/issues/79 >> [2] https://github.com/KSPP/linux/issues/86 >> >> Tested-by: kernel test robot <lkp@intel.com> >> Link: https://github.com/GustavoARSilva/linux-hardening/blob/master/cii/0-day/tty-20200716.md >> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> > > Acked-by: Jiri Slaby <jirislaby@kernel.org> > > thanks, >
| |