Messages in this thread | | | Subject | Re: [RFC PATCH v2 2/6] ALSA: compress: add new ioctl for setting codec parameters | From | Pierre-Louis Bossart <> | Date | Wed, 22 Jul 2020 10:36:02 -0500 |
| |
>>> * and the stream properties >>> + * @set_codec_params: Sets the compressed stream codec parameters, >>> Optional >>> + * This can be called in during gapless next track codec change only >>> to set >>> + * codec params >> >> Would it be clearer if this was called set_next_codec_params()? or >> set_next_track_codec_params()? >> >> Having set_params() and set_codec_params() is a bit confusing since >> the semantic difference is not captured in the callback name. > > set_next_track_codec_params seems more sensible as its next track params. > Will change this in next version!
maybe set_params() and set_next_track_params() are enough, not sure if the codec reference helps?
| |