lkml.org 
[lkml]   [2020]   [Jul]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [RFC PATCH v2 2/6] ALSA: compress: add new ioctl for setting codec parameters
From
Date



>>>    * and the stream properties
>>> + * @set_codec_params: Sets the compressed stream codec parameters,
>>> Optional
>>> + * This can be called in during gapless next track codec change only
>>> to set
>>> + * codec params
>>
>> Would it be clearer if this was called set_next_codec_params()? or
>> set_next_track_codec_params()?
>>
>> Having set_params() and set_codec_params() is a bit confusing since
>> the semantic difference is not captured in the callback name.
>
> set_next_track_codec_params seems more sensible as its next track params.
> Will change this in next version!

maybe set_params() and set_next_track_params() are enough, not sure if
the codec reference helps?

\
 
 \ /
  Last update: 2020-07-22 17:39    [W:0.399 / U:0.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site