Messages in this thread | | | From | Avri Altman <> | Subject | RE: [PATCH v6 0/5] scsi: ufs: Add Host Performance Booster Support | Date | Wed, 22 Jul 2020 06:18:21 +0000 |
| |
> > Avri, > > > Martin - Can we move forward with this one? > > CHECK drivers/scsi/ufs/ufshcd-pltfrm.c > drivers/scsi/ufs/ufsfeature.c:90:20: warning: symbol 'ufshpb_dev_type' was > not declared. Should it be static? > drivers/scsi/ufs/ufsfeature.c:104:17: warning: symbol 'ufsf_bus_type' was not > declared. Should it be static? > CC [M] drivers/scsi/ufs/ufsfeature.o > CC [M] drivers/scsi/ufs/ufs_bsg.o > CC [M] drivers/scsi/ufs/ufs-sysfs.o > drivers/scsi/ufs/ufshpb.c:18:14: warning: symbol 'ufshpb_host_map_kbytes' > was not declared. Should it be static? > drivers/scsi/ufs/ufshpb.c:793:28: warning: mixing different enum types: > drivers/scsi/ufs/ufshpb.c:793:28: unsigned int enum HPB_RGN_STATE > drivers/scsi/ufs/ufshpb.c:793:28: unsigned int enum HPB_SRGN_STATE > CC [M] drivers/scsi/ufs/ufshcd.o > drivers/scsi/ufs/ufshpb.c:1026:31: warning: context imbalance in > 'ufshpb_run_active_subregion_list' - different lock contexts for basic block
Martin - Thanks.
Daejun - please run Sparse as well, not just checkpatch to eliminate those warnings.
Thanks, Avri
| |