lkml.org 
[lkml]   [2020]   [Jul]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v31 03/12] leds: lp50xx: Add the LP50XX family of the RGB LED driver
Hi!

> > > > > + ret = fwnode_property_read_u32_array(child,
> > > > > + "reg",
> > > > > + led_banks,
> > > > > + ret);
> > > > Move this to subfunction to reduce the indentation? (Or, just refactor
> > > > it somehow).
> > > Actually I can just put it all on the same line since the 80 character
> > > requirement is relaxed.
> > No.
> >
> > You have too long and too complex function, with too many blocks
> > inside each other. Please fix it.
>
> I will refactor

Thank you.
Pavel

\
 
 \ /
  Last update: 2020-07-22 14:41    [W:0.047 / U:0.340 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site