Messages in this thread | | | Date | Wed, 22 Jul 2020 14:18:34 +0300 | From | Laurent Pinchart <> | Subject | Re: [PATCH v1 1/1] drm/bridge: nwl-dsi: Drop DRM_BRIDGE_ATTACH_NO_CONNECTOR check. |
| |
Hi Guido,
Thank you for the patch.
On Sat, Jul 18, 2020 at 08:26:37PM +0200, Guido Günther wrote: > We don't create a connector but let panel_bridge handle that so there's > no point in rejecting DRM_BRIDGE_ATTACH_NO_CONNECTOR. > > Signed-off-by: Guido Günther <agx@sigxcpu.org>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> --- > drivers/gpu/drm/bridge/nwl-dsi.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/nwl-dsi.c b/drivers/gpu/drm/bridge/nwl-dsi.c > index 77a79af70914..ce94f797d090 100644 > --- a/drivers/gpu/drm/bridge/nwl-dsi.c > +++ b/drivers/gpu/drm/bridge/nwl-dsi.c > @@ -918,11 +918,6 @@ static int nwl_dsi_bridge_attach(struct drm_bridge *bridge, > struct drm_panel *panel; > int ret; > > - if (flags & DRM_BRIDGE_ATTACH_NO_CONNECTOR) { > - DRM_ERROR("Fix bridge driver to make connector optional!"); > - return -EINVAL; > - } > - > ret = drm_of_find_panel_or_bridge(dsi->dev->of_node, 1, 0, &panel, > &panel_bridge); > if (ret)
-- Regards,
Laurent Pinchart
| |