Messages in this thread | | | Date | Wed, 22 Jul 2020 13:05:28 +0200 | From | Johan Hovold <> | Subject | Re: [PATCH 4.19 094/133] USB: serial: iuu_phoenix: fix memory corruption |
| |
On Wed, Jul 22, 2020 at 12:52:47PM +0200, Pavel Machek wrote:
> > > Ok, so... goto and label is unneccessary, memcpy will do the right > > > thing with count == 0. > > > > That's generally too subtle. Better to clearly mark the error/exception > > path. > > We usually avoid subtle code by introducing comments, not by > introducing extra (and confusing) code that can not be optimized out.
It's not confusing at all. Just drop it.
Johan [unhandled content-type:application/pgp-signature] | |