lkml.org 
[lkml]   [2020]   [Jul]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] sysrq: use only one slot for loglevels in key table
On Wed, Jul 22, 2020 at 05:26:09PM +0800, Yue Hu wrote:
> From: Yue Hu <huyue2@yulong.com>
>
> Currently, sysrq_key_table[] has 10 slots for same interface to change
> console loglevel. No specific purpose to do that. Let's use only one slot
> to save memory space. Also, update the key2index calculation. And remove
> needless code in help message print path to make the logic simpler.

That sounds like a lot of different things being all done at once. Can
you break this up into individual patches, each only doing one type of
thing at a time.

And if you are saving memory, please show how much you really are
saving.

thanks,

greg k-h

\
 
 \ /
  Last update: 2020-07-22 12:51    [W:0.041 / U:0.104 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site