Messages in this thread | | | Subject | Re: [PATCH v2 1/1] nvmem: qcom-spmi-sdam: Enable multiple devices | From | Srinivas Kandagatla <> | Date | Wed, 22 Jul 2020 10:32:49 +0100 |
| |
On 21/07/2020 20:46, Guru Das Srinagesh wrote: > Using pdev->id as the nvmem's config ID (which, by default, is > NVMEM_DEVID_NONE) prevents multiple instances of this driver from > probing because of the following error: > > sysfs: cannot create duplicate filename '/bus/nvmem/devices/spmi_sdam' > > Use NVMEM_DEVID_AUTO as the NVMEM config ID to fix the issue. > > Signed-off-by: Guru Das Srinagesh <gurus@codeaurora.org> > --- > drivers/nvmem/qcom-spmi-sdam.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-)
Applied thanks,
--srini > > diff --git a/drivers/nvmem/qcom-spmi-sdam.c b/drivers/nvmem/qcom-spmi-sdam.c > index 8682cda..a72704c 100644 > --- a/drivers/nvmem/qcom-spmi-sdam.c > +++ b/drivers/nvmem/qcom-spmi-sdam.c > @@ -1,6 +1,6 @@ > // SPDX-License-Identifier: GPL-2.0-only > /* > - * Copyright (c) 2017 The Linux Foundation. All rights reserved. > + * Copyright (c) 2017, 2020 The Linux Foundation. All rights reserved. > */ > > #include <linux/device.h> > @@ -141,7 +141,7 @@ static int sdam_probe(struct platform_device *pdev) > > sdam->sdam_config.dev = &pdev->dev; > sdam->sdam_config.name = "spmi_sdam"; > - sdam->sdam_config.id = pdev->id; > + sdam->sdam_config.id = NVMEM_DEVID_AUTO; > sdam->sdam_config.owner = THIS_MODULE, > sdam->sdam_config.stride = 1; > sdam->sdam_config.word_size = 1; >
| |