Messages in this thread | | | Date | Wed, 22 Jul 2020 09:10:55 +0200 | From | Pavel Machek <> | Subject | Re: [PATCH v31 03/12] leds: lp50xx: Add the LP50XX family of the RGB LED driver |
| |
Hi!
> >>+ ret = fwnode_property_read_u32_array(child, > >>+ "reg", > >>+ led_banks, > >>+ ret); > >Move this to subfunction to reduce the indentation? (Or, just refactor > >it somehow). > > Actually I can just put it all on the same line since the 80 character > requirement is relaxed.
No.
You have too long and too complex function, with too many blocks inside each other. Please fix it.
Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html [unhandled content-type:application/pgp-signature] | |