Messages in this thread | | | Date | Wed, 22 Jul 2020 16:42:30 -0700 (PDT) | From | Chi Song <> | Subject | Re: [PATCH v6 net-next] net: hyperv: Add attributes to show TX indirection table |
| |
On Tue, 21 Jul 2020, Florian Fainelli wrote:
> On 7/21/20 12:21 PM, Jakub Kicinski wrote: > > On Tue, 21 Jul 2020 04:58:59 +0000 Chi Song wrote: > >> An imbalanced TX indirection table causes netvsc to have low > >> performance. This table is created and managed during runtime. To help > >> better diagnose performance issues caused by imbalanced tables, add > >> device attributes to show the content of TX indirection tables. > >> > >> Signed-off-by: Chi Song <chisong@microsoft.com> > > > > Sorry for waiting until v6 but sysfs feel like a very strange place to > > expose this. Especially under the netdev, not the bus device. > > > > This looks like device specific state, perhaps ethtool -d is a more > > appropriate place? > > Agreed, or a devlink resource maybe?
Thank you for comments, I will move it to ethtool.
| |