lkml.org 
[lkml]   [2020]   [Jul]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v2 1/4] dt-bindings: hwlock: qcom: Migrate binding to YAML
On Mon, Jun 22, 2020 at 1:59 AM Bjorn Andersson
<bjorn.andersson@linaro.org> wrote:
>
> Migrate the Qualcomm TCSR mutex binding to YAML to allow validation.
>
> Reviewed-by: Vinod Koul <vkoul@kernel.org>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---
>
> Changes since v1:
> - Actually remove the old binding doc
>
> .../bindings/hwlock/qcom-hwspinlock.txt | 39 --------------
> .../bindings/hwlock/qcom-hwspinlock.yaml | 51 +++++++++++++++++++
> 2 files changed, 51 insertions(+), 39 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/hwlock/qcom-hwspinlock.txt
> create mode 100644 Documentation/devicetree/bindings/hwlock/qcom-hwspinlock.yaml

[...]

> diff --git a/Documentation/devicetree/bindings/hwlock/qcom-hwspinlock.yaml b/Documentation/devicetree/bindings/hwlock/qcom-hwspinlock.yaml
> new file mode 100644
> index 000000000000..71e63b52edd5
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwlock/qcom-hwspinlock.yaml
> @@ -0,0 +1,51 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/hwlock/qcom-hwspinlock.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Qualcomm Hardware Mutex Block
> +
> +maintainers:
> + - Bjorn Andersson <bjorn.andersson@linaro.org>
> +
> +description:
> + The hardware block provides mutexes utilized between different processors on
> + the SoC as part of the communication protocol used by these processors.
> +
> +properties:
> + compatible:
> + enum:
> + - qcom,sfpb-mutex
> + - qcom,tcsr-mutex
> +
> + '#hwlock-cells':
> + const: 1
> +
> + syscon:
> + $ref: "/schemas/types.yaml#/definitions/phandle-array"
> + description:
> + Should be a triple of phandle referencing the TCSR mutex syscon, offset
> + of first mutex within the syscon and stride between each mutex.
> +
> +required:
> + - compatible
> + - '#hwlock-cells'
> + - syscon
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + tcsr_mutex_block: syscon@fd484000 {
> + compatible = "syscon";

'syscon' alone now generates warnings. Can you drop this node or add a
specific compatible.

> + reg = <0xfd484000 0x2000>;
> + };
> +
> + hwlock {
> + compatible = "qcom,tcsr-mutex";
> + syscon = <&tcsr_mutex_block 0 0x80>;
> +
> + #hwlock-cells = <1>;
> + };
> +...
> --
> 2.26.2
>

\
 
 \ /
  Last update: 2020-07-21 17:14    [W:0.112 / U:0.368 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site