lkml.org 
[lkml]   [2020]   [Jul]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v15 2/3] drivers: input:keyboard: Add mtk keypad driver
On Tue, Jul 21, 2020 at 3:38 PM Mattijs Korpershoek
<mkorpershoek@baylibre.com> wrote:
> Fengping yu <fengping.yu@mediatek.com> writes:

> > This adds matrix keypad support for Mediatek SoCs.

...

> > + keypad->regmap = devm_regmap_init_mmio(&pdev->dev,
> > + keypad->base,
> > + &keypad_regmap_cfg);
> > + if (IS_ERR(keypad->regmap)) {
> > + dev_err(&pdev->dev,
> > + "regmap init failed:%ld\n", PTR_ERR(keypad->regmap));
> > + return PTR_ERR(keypad->regmap);
> > + }

Okay, because another comment appeared, I would suggest to switch to
%pe at the same time.

dev_err(&pdev->dev, "regmap init failed: %pe\n", keypad->regmap);

--
With Best Regards,
Andy Shevchenko

\
 
 \ /
  Last update: 2020-07-21 16:24    [W:0.530 / U:0.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site