Messages in this thread | | | Subject | Re: [PATCH] clocksource/drivers/timer-ti-dm: Fix suspend and resume for am3 and am4 | From | Carlos Hernandez <> | Date | Tue, 21 Jul 2020 09:11:29 -0400 |
| |
On 7/17/20 6:29 AM, Daniel Lezcano wrote: > On 13/07/2020 18:26, Tony Lindgren wrote: >> Carlos Hernandez <ceh@ti.com> reported that we now have a suspend and >> resume regresssion on am3 and am4 compared to the earlier kernels. While >> suspend and resume works with v5.8-rc3, we now get errors with rtcwake: >> >> pm33xx pm33xx: PM: Could not transition all powerdomains to target state >> ... >> rtcwake: write error >> >> This is because we now fail to idle the system timer clocks that the >> idle code checks and the error gets propagated to the rtcwake. >> >> Turns out there are several issues that need to be fixed: >> >> 1. Ignore no-idle and no-reset configured timers for the ti-sysc >> interconnect target driver as otherwise it will keep the system timer >> clocks enabled >> >> 2. Toggle the system timer functional clock for suspend for am3 and am4 >> (but not for clocksource on am3) >> >> 3. Only reconfigure type1 timers in dmtimer_systimer_disable() >> >> 4. Use of_machine_is_compatible() instead of of_device_is_compatible() >> for checking the SoC type >> >> Fixes: 52762fbd1c47 ("clocksource/drivers/timer-ti-dm: Add clockevent and clocksource support") >> Reported-by: Carlos Hernandez <ceh@ti.com> >> Signed-off-by: Tony Lindgren <tony@atomide.com> >> ---
Tested-by: Carlos Hernandez <ceh@ti.com>
> Carlos, were you able to test this patch ? > -- Carlos
| |