Messages in this thread | | | From | ivan <> | Date | Tue, 21 Jul 2020 18:40:08 +0800 | Subject | Re: [PATCH v5 4/4] power: supply: core: property to control reverse charge |
| |
On Tue, Jul 21, 2020 at 4:21 PM Greg KH <gregkh@linuxfoundation.org> wrote: > > On Tue, Jul 21, 2020 at 01:59:37PM +0800, Qiwu Huang wrote: > > From: Qiwu Huang <huangqiwu@xiaomi.com> > > > > Interface to control wireless reverse charge. > > Supply reverse charge function when enabled. > > > > Signed-off-by: Qiwu Huang <huangqiwu@xiaomi.com> > > --- > > Documentation/ABI/testing/sysfs-class-power | 12 ++++++++++++ > > drivers/power/supply/power_supply_sysfs.c | 1 + > > include/linux/power_supply.h | 1 + > > 3 files changed, 14 insertions(+) > > > > diff --git a/Documentation/ABI/testing/sysfs-class-power b/Documentation/ABI/testing/sysfs-class-power > > index 75ec7de2fe78..54647d6995d3 100644 > > --- a/Documentation/ABI/testing/sysfs-class-power > > +++ b/Documentation/ABI/testing/sysfs-class-power > > @@ -767,3 +767,15 @@ Description: > > > > Access: Read-Only > > Valid values: 0 - 100 > > + > > +What: /sys/class/power_supply/<supply_name>/reverse_chg_mode > > +Date: Jul 2020 > > +Contact: Fei Jiang <jiangfei1@xiaomi.com> > > +Description: > > + Some phones support wireless reverse charge function which charge other phones. > > Replace "phones" with "devices"?
Yes, devices better than phones
> > And shouldn't these lines be wrapped properly at 72 colums or so?
Sorry, I will modify the format to match this standard.
> > > + The property supply interface to control wireless reverse charge. > > I can't understand this sentance.
The property provider interface to enable/disable wireless reverse charge.
> > > + If enabled, start TX mode and detect RX. Disabled when timeout or manual setting. > > Can this be set, or is it just something to be read?
Sorry,I forgot the permission statement
Access: Read, Write
> > thanks, > > greg k-h
-- Thanks
Qiwu
| |