lkml.org 
[lkml]   [2020]   [Jul]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 1/2] net: dsa: Add flag for 802.1AD when adding VLAN for dsa switch and port
    From
    Date


    On 7/20/2020 3:41 AM, hongbo.wang@nxp.com wrote:
    > From: "hongbo.wang" <hongbo.wang@nxp.com>
    >
    > the following command can be supported:
    > ip link add link swp1 name swp1.100 type vlan protocol 802.1ad id 100

    You should probably include the switch driver that is going to be
    benefiting from doing these changes in the patch series, provide a cover
    letter when sending more than one patch, and also combine both the add
    and delete parts.

    Since you already have visibility into proto, it may not be necessary at
    all for now to define a BRIDGE_VLAN_INFO_8021AD bit in order to pass
    that flag down to DSA for programming the VLAN, just pass proto to
    dsa_port_vid_add() or a boolean flag which indicates whether this is the
    customer or service tag that you are trying to program?
    --
    Florian

    \
     
     \ /
      Last update: 2020-07-21 06:58    [W:3.986 / U:0.208 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site