Messages in this thread | | | From | Vitaly Kuznetsov <> | Subject | Re: [PATCH] KVM: Using macros instead of magic values | Date | Tue, 21 Jul 2020 10:46:47 +0200 |
| |
Haiwei Li <lihaiwei.kernel@gmail.com> writes:
> From: Haiwei Li <lihaiwei@tencent.com> > > Instead of using magic values, use macros. > > Signed-off-by: Haiwei Li <lihaiwei@tencent.com> > --- > arch/x86/kvm/lapic.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/arch/x86/kvm/lapic.c b/arch/x86/kvm/lapic.c > index 47801a4..d5fb2ea 100644 > --- a/arch/x86/kvm/lapic.c > +++ b/arch/x86/kvm/lapic.c > @@ -2083,7 +2083,8 @@ int kvm_lapic_reg_write(struct kvm_lapic *apic, > u32 reg, u32 val) > > case APIC_SELF_IPI: > if (apic_x2apic_mode(apic)) { > - kvm_lapic_reg_write(apic, APIC_ICR, 0x40000 | (val & 0xff)); > + kvm_lapic_reg_write(apic, APIC_ICR, > + APIC_DEST_SELF | (val & APIC_VECTOR_MASK)); > } else > ret = 1; > break; > -- > 1.8.3.1 >
Reviewed-by: Vitaly Kuznetsov <vkuznets@redhat.com>
-- Vitaly
| |