lkml.org 
[lkml]   [2020]   [Jul]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] sparc32: fix a user-triggerable oops in clear_user()
From
From: Al Viro <viro@zeniv.linux.org.uk>
Date: Mon, 20 Jul 2020 02:21:51 +0100

> Back in 2.1.29 the clear_user() guts (__bzero()) had been merged
> with memset(). Unfortunately, while all exception handlers had been
> copied, one of the exception table entries got lost. As the result,
> clear_user() starting at 128*n bytes before the end of page and
> spanning between 8 and 127 bytes into the next page would oops when
> the second page is unmapped. It's trivial to reproduce - all
> it takes is
>
> main()
> {
> int fd = open("/dev/zero", O_RDONLY);
> char *p = mmap(NULL, 16384, PROT_READ|PROT_WRITE,
> MAP_PRIVATE|MAP_ANON, -1, 0);
> munmap(p + 8192, 8192);
> read(fd, p + 8192 - 128, 192);
> }
>
> which had been oopsing since March 1997. Says something about
> the quality of test coverage... ;-/ And while today sparc32 port
> is nearly dead, back in '97 it had been very much alive; in fact,
> sparc64 had only been in mainline for 3 months by that point...
>
> Cc: stable@kernel.org
> Fixes: v2.1.29
> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

Applied, thanks Al.

\
 
 \ /
  Last update: 2020-07-22 03:25    [W:2.256 / U:0.208 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site