lkml.org 
[lkml]   [2020]   [Jul]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH RFC V2 17/17] x86/entry: Preserve PKRS MSR across exceptions
    On Tue, Jul 21, 2020 at 11:01:34AM -0700, Ira Weiny wrote:
    > On Fri, Jul 17, 2020 at 11:30:41AM +0200, Peter Zijlstra wrote:
    > > On Fri, Jul 17, 2020 at 12:20:56AM -0700, ira.weiny@intel.com wrote:
    > > > +static void noinstr idt_save_pkrs(idtentry_state_t state)
    > >
    > > noinstr goes in the same place you would normally put inline, that's
    > > before the return type, not after it.
    > >
    >
    > Sorry about that. But that does not look to be consistent.
    >
    > 10:57:35 > git grep 'noinstr' arch/x86/entry/common.c
    > ...
    > arch/x86/entry/common.c:idtentry_state_t noinstr idtentry_enter(struct pt_regs *regs)
    > arch/x86/entry/common.c:void noinstr idtentry_exit(struct pt_regs *regs, idtentry_state_t state)
    > arch/x86/entry/common.c:void noinstr idtentry_enter_user(struct pt_regs *regs)
    > arch/x86/entry/common.c:void noinstr idtentry_exit_user(struct pt_regs *regs)
    > ...
    >
    > Are the above 'wrong'? Is it worth me sending a patch?

    I think I already fixed all those, please check tip/master.

    \
     
     \ /
      Last update: 2020-07-21 21:12    [W:4.303 / U:2.228 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site