Messages in this thread | | | Date | Mon, 20 Jul 2020 15:35:33 +0100 | From | Mark Brown <> | Subject | Re: [PATCH v3 4/4] regulator: core: Add voltage support for sync_state() callbacks |
| |
On Wed, Jul 15, 2020 at 09:20:53PM -0700, Saravana Kannan wrote:
> - if (!handoff) > + if (!handoff) { > regulator_disable(rdev->boot_limits); > - else > + regulator_set_voltage(rdev->boot_limits, 0, INT_MAX); > + } else { > rdev->use_count--; > + } > destroy_regulator(rdev->boot_limits);
These sets should be completely redundant since they will go away when the regulator is destroyed, if there's an issue with that we should fix it rather than bodging around it. [unhandled content-type:application/pgp-signature] | |