Messages in this thread | | | Subject | Re: [PATCH] clk: ti: clkctrl: add the missed kfree() for _ti_omap4_clkctrl_setup() | From | Markus Elfring <> | Date | Mon, 20 Jul 2020 16:19:06 +0200 |
| |
… > +++ b/drivers/clk/ti/clkctrl.c > @@ -655,8 +655,10 @@ static void __init _ti_omap4_clkctrl_setup(struct device_node *node) > } > > hw = kzalloc(sizeof(*hw), GFP_KERNEL); > - if (!hw) > + if (!hw) { > + kfree(clkctrl_name); > return; > + } …
I suggest to use an additional label instead.
if (!hw) - return; + goto free_control_name;
By the way: How do you think about to replace the label “cleanup” by other jump targets for better exception handling in this function implementation?
Regards, Markus
| |