Messages in this thread | | | Subject | Re: [PATCH] f2fs: compress: fix to avoid memory leak on cc->cpages | From | Chao Yu <> | Date | Mon, 20 Jul 2020 20:28:35 +0800 |
| |
On 2020/7/20 16:52, Chao Yu wrote: > Memory allocated for storing compressed pages' poitner should be > released after f2fs_write_compressed_pages(), otherwise it will > cause memory leak issue.
Jaegeuk,
Please help to add below tag when merging, thanks.
Fixes: 4c8ff7095bef ("f2fs: support data compression")
> > Signed-off-by: Chao Yu <yuchao0@huawei.com> > --- > fs/f2fs/compress.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/fs/f2fs/compress.c b/fs/f2fs/compress.c > index 3a847bc36748..a20c9f3272af 100644 > --- a/fs/f2fs/compress.c > +++ b/fs/f2fs/compress.c > @@ -1385,6 +1385,8 @@ int f2fs_write_multi_pages(struct compress_ctx *cc, > err = f2fs_write_compressed_pages(cc, submitted, > wbc, io_type); > cops->destroy_compress_ctx(cc); > + kfree(cc->cpages); > + cc->cpages = NULL; > if (!err) > return 0; > f2fs_bug_on(F2FS_I_SB(cc->inode), err != -EAGAIN); >
| |