Messages in this thread | | | From | <> | Subject | R: [PATCH v10 1/2] phy: qualcomm: add qcom ipq806x dwc usb phy driver | Date | Mon, 20 Jul 2020 14:25:18 +0200 |
| |
> -----Messaggio originale----- > Da: Vinod Koul <vkoul@kernel.org> > Inviato: lunedì 20 luglio 2020 08:26 > A: Ansuel Smith <ansuelsmth@gmail.com> > Cc: Andy Gross <agross@codeaurora.org>; Jonathan McDowell > <noodles@earth.li>; Andy Gross <agross@kernel.org>; Bjorn Andersson > <bjorn.andersson@linaro.org>; Kishon Vijay Abraham I <kishon@ti.com>; > Rob Herring <robh+dt@kernel.org>; Mark Rutland > <mark.rutland@arm.com>; linux-arm-msm@vger.kernel.org; linux- > kernel@vger.kernel.org; devicetree@vger.kernel.org > Oggetto: Re: [PATCH v10 1/2] phy: qualcomm: add qcom ipq806x dwc usb > phy driver > > On 17-07-20, 15:16, Ansuel Smith wrote: > > This has lost in the original push for the dwc3 qcom driver. > > This is needed for ipq806x SoC as without this the usb ports > > doesn't work at all. > > Applied both, thanks > > My script found below errors with W=1, can you please send fixes for > these >
Since you applied them should I send a new patch or a v11 of this patchset?
> drivers/phy/qualcomm/phy-qcom-ipq806x-usb.c:140: warning: Function > parameter or member 'phy_dwc3' not described in > 'usb_phy_write_readback' > drivers/phy/qualcomm/phy-qcom-ipq806x-usb.c:140: warning: Function > parameter or member 'offset' not described in 'usb_phy_write_readback' > drivers/phy/qualcomm/phy-qcom-ipq806x-usb.c:140: warning: Function > parameter or member 'mask' not described in 'usb_phy_write_readback' > drivers/phy/qualcomm/phy-qcom-ipq806x-usb.c:140: warning: Function > parameter or member 'val' not described in 'usb_phy_write_readback' > drivers/phy/qualcomm/phy-qcom-ipq806x-usb.c:182: warning: Function > parameter or member 'phy_dwc3' not described in 'usb_ss_write_phycreg' > drivers/phy/qualcomm/phy-qcom-ipq806x-usb.c:182: warning: Function > parameter or member 'addr' not described in 'usb_ss_write_phycreg' > drivers/phy/qualcomm/phy-qcom-ipq806x-usb.c:182: warning: Function > parameter or member 'val' not described in 'usb_ss_write_phycreg' > drivers/phy/qualcomm/phy-qcom-ipq806x-usb.c:219: warning: Function > parameter or member 'phy_dwc3' not described in 'usb_ss_read_phycreg' > drivers/phy/qualcomm/phy-qcom-ipq806x-usb.c:219: warning: Function > parameter or member 'addr' not described in 'usb_ss_read_phycreg' > drivers/phy/qualcomm/phy-qcom-ipq806x-usb.c:219: warning: Function > parameter or member 'val' not described in 'usb_ss_read_phycreg' > > -- > ~Vinod
| |