lkml.org 
[lkml]   [2020]   [Jul]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH] ipmi: Remove duplicate code in __ipmi_bmc_register()
    From
    Date
    > > __ipmi_bmc_register() jumps to the label 'out_free_my_dev_name' in an
    > > error path. So we can remove duplicate code in the if (rv).
    >
    > Looks correct, queued for next release.

    1. Can an imperative wording be preferred for the change description?

    2. Will the tag “Fixes” become helpful for the commit message?

    3. Did you avoid a typo in the patch subject?

    Regards,
    Markus

    \
     
     \ /
      Last update: 2020-07-20 14:09    [W:3.392 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site