lkml.org 
[lkml]   [2020]   [Jul]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v31 01/12] leds: multicolor: Introduce a multicolor class definition
From
Date
Pavel

On 7/20/20 4:54 AM, Pavel Machek wrote:
> Hi!
>
>> Introduce a multicolor class that groups colored LEDs
>> within a LED node.
>>
>> The multicolor class groups monochrome LEDs and allows controlling two
>> aspects of the final combined color: hue and lightness. The former is
>> controlled via the intensity file and the latter is controlled
>> via brightness file.
>>
>> Acked-by: Jacek Anaszewski <jacek.anaszewski@gmail.com>
>> Signed-off-by: Dan Murphy <dmurphy@ti.com>
> Thanks, applied and pushed out.

Thank you. What about the patches for the users?

>> +====================================
>> +MultiColor LED handling under Linux
>> +====================================
> ...
>> +Multicolor Class Control
>> +========================
> AFAICT The first one should be "Multicolor" for consistency.
>
>> +config LEDS_CLASS_MULTICOLOR
>> + tristate "LED MultiColor Class Support"
> Here too.
>
> Can you send a followup patch to fix it up?

Will send a patch to fix it up but not sure if I should send as part of
this series or separately?

Because I am not sure if you are going to apply the remaining patches up
to the DTs

Dan


> Best regards,
> Pavel

\
 
 \ /
  Last update: 2020-07-20 14:09    [W:0.070 / U:0.184 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site