Messages in this thread | | | Date | Mon, 20 Jul 2020 15:12:19 +0530 | From | Sai Prakash Ranjan <> | Subject | Re: [PATCH V2] soc: qcom: geni: Fix NULL pointer dereference |
| |
On 2020-07-20 15:06, Akash Asthana wrote: > pdev struct doesn't exists for the devices whose status are disabled > from DT node, in such cases NULL is returned from > 'of_find_device_by_node' > Later when we try to get drvdata from pdev struct NULL pointer > dereference > is triggered. > > Add a NULL check for return values to fix the issue. > > We were hitting this issue when one of QUP is disabled. > > Fixes: 048eb908a1f2 ("soc: qcom-geni-se: Add interconnect support to > fix earlycon crash") > Reported-by: Sai Prakash Ranjan <saipraka@codeaurora.org> > Reviewed-by: Matthias Kaehlcke <mka@chromium.org> > Signed-off-by: Akash Asthana <akashast@codeaurora.org>
Nit: my codeaurora mail address is <saiprakash.ranjan@codeaurora.org>. I don't think you have to resend for this small change, hopefully maintainers are ok to fix this when applying.
Reported-by: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org> Tested-by: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
-Sai
-- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
| |